Skip to content

CNTRLPLANE-3870: add periodic e2e-aro-hcp test for release-5.0 - #82403

Open
Nirshal wants to merge 2 commits into
openshift:mainfrom
Nirshal:CNTRLPLANE-3870/add-e2e-aro-hcp-periodic
Open

CNTRLPLANE-3870: add periodic e2e-aro-hcp test for release-5.0#82403
Nirshal wants to merge 2 commits into
openshift:mainfrom
Nirshal:CNTRLPLANE-3870/add-e2e-aro-hcp-periodic

Conversation

@Nirshal

@Nirshal Nirshal commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

Adds a daily periodic version of the e2e-aro-hcp test to the release-5.0 periodics config. The test already exists as a presubmit on main (first successful run on PR #9031) and needs a periodic counterpart so it can be registered as an informing test on the HO Konflux release controller.

Once the periodic job accumulates enough runs and proves consistently green, it will be promoted to a required (blocking) test.

The periodic job uses the same configuration as the existing presubmit:

  • Cluster profile: aro-hcp-dev
  • Workflow: aro-hcp-hypershift-e2e (provisions an isolated ARO HCP environment, pushes HO/CPO images, runs e2e tests)
  • Schedule: daily at 02:00 UTC (0 2 * * *), consistent with other blocking tests in the gate

A follow-up MR on konflux-release-data will add the generated job name (periodic-ci-openshift-hypershift-release-5.0-periodics-e2e-aro-hcp) to the ITS e2e-informing-job-names list.

Special notes for your reviewer:

This periodic is added to release-5.0 only, to match the existing blocking tests in the HO release gate ITS. The original request (CNTRLPLANE-3870) does not specify whether it should also be added for other release branches (e.g. release-4.22). Please advise if we should extend coverage.

Which issue(s) this PR fixes:

CNTRLPLANE-3870

Checklist:

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Summary by CodeRabbit

Updates the OpenShift CI HyperShift release-5.0 periodics configuration in openshift/release by adding an ARO HCP daily end-to-end job (e2e-aro-hcp) scheduled at 02:00 UTC. The job uses the aro-hcp-dev cluster profile and the aro-hcp-hypershift-e2e workflow, and sets ARO/HCP-specific environment variables (e.g., allowed subscriptions, cloud/deploy env, and multistage parameter override). It also adds aro-hcp-e2e-tests and aro-hcp-e2e-tools as periodic base_images so the workflow can resolve required images in the periodic context without performing a source build.

…lease-5.0

Add a daily periodic version of the e2e-aro-hcp presubmit test
to the release-5.0 periodics config. This is needed to register
the test as an informing gate on the HO release controller.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 24, 2026
@openshift-ci-robot

openshift-ci-robot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

@Nirshal: This pull request references CNTRLPLANE-3870 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "5.0.0" version, but no target version was set.

Details

In response to this:

What this PR does / why we need it:

Adds a daily periodic version of the e2e-aro-hcp test to the release-5.0 periodics config. The test already exists as a presubmit on main (first successful run on PR #9031) and needs a periodic counterpart so it can be registered as an informing test on the HO Konflux release controller.

Once the periodic job accumulates enough runs and proves consistently green, it will be promoted to a required (blocking) test.

The periodic job uses the same configuration as the existing presubmit:

  • Cluster profile: aro-hcp-dev
  • Workflow: aro-hcp-hypershift-e2e (provisions an isolated ARO HCP environment, pushes HO/CPO images, runs e2e tests)
  • Schedule: daily at 02:00 UTC (0 2 * * *), consistent with other blocking tests in the gate

A follow-up MR on konflux-release-data will add the generated job name (periodic-ci-openshift-hypershift-release-5.0-periodics-e2e-aro-hcp) to the ITS e2e-informing-job-names list.

Special notes for your reviewer:

This periodic is added to release-5.0 only, to match the existing blocking tests in the HO release gate ITS. The original request (CNTRLPLANE-3870) does not specify whether it should also be added for other release branches (e.g. release-4.22). Please advise if we should extend coverage.

Which issue(s) this PR fixes:

CNTRLPLANE-3870

Checklist:

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
openshift-ci Bot requested review from devguyio and ironcladlou July 24, 2026 13:29
@coderabbitai

coderabbitai Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 9163ae72-59af-4479-a317-dc4a771006f1

📥 Commits

Reviewing files that changed from the base of the PR and between d672f72 and c80ee14.

📒 Files selected for processing (1)
  • ci-operator/config/openshift/hypershift/openshift-hypershift-release-5.0__periodics.yaml
🚧 Files skipped from review as they are similar to previous changes (1)
  • ci-operator/config/openshift/hypershift/openshift-hypershift-release-5.0__periodics.yaml

Walkthrough

A daily e2e-aro-hcp periodic test is configured for the Hypershift 5.0 release with ARO HCP base images, the aro-hcp-dev cluster profile, ARO/HCP environment settings, and the aro-hcp-hypershift-e2e workflow.

Changes

ARO HCP periodic test

Layer / File(s) Summary
Configure ARO HCP periodic test
ci-operator/config/openshift/hypershift/openshift-hypershift-release-5.0__periodics.yaml
Adds ARO HCP E2E base images and the daily e2e-aro-hcp test with its cluster profile, environment configuration, and workflow.

Estimated code review effort: 2 (Simple) | ~5 minutes

Possibly related PRs

Suggested reviewers: ironcladlou, devguyio

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: adding the periodic e2e-aro-hcp test for release-5.0.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed No Ginkgo test titles were added or modified; the PR only changes periodic YAML job config, so the stability rule is not applicable.
Test Structure And Quality ✅ Passed PR only changes a periodic YAML config; no Ginkgo test code or test logic was added or modified, so the test-quality checklist is not applicable.
Microshift Test Compatibility ✅ Passed PASS: The PR only edits ci-operator periodic YAML; no new Ginkgo tests or test code were added, so the MicroShift compatibility check is not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR only adds a periodic ci-operator job/config entry; no new Ginkgo It/Describe/Context/When tests were introduced.
Topology-Aware Scheduling Compatibility ✅ Passed PASS: PR only adds a periodic CI job and base images in YAML; no deployment manifests, controllers, or scheduling fields (nodeSelectors/affinity/PDBs) were introduced.
Ote Binary Stdout Contract ✅ Passed Only a ci-operator YAML config changed; no process-level binary code or stdout writes were introduced.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed No Ginkgo/e2e test code was added; the PR only adds a periodic YAML job, so the IPv4/external-connectivity check is not applicable.
No-Weak-Crypto ✅ Passed Patch only adds YAML periodic config/base images and env vars; no MD5/SHA1/DES/RC4/3DES/Blowfish/ECB, custom crypto, or secret comparisons found.
Container-Privileges ✅ Passed Only adds base_images in a ci-operator periodic YAML; no privileged/hostNetwork/hostPID/hostIPC/SYS_ADMIN/allowPrivilegeEscalation settings were introduced.
No-Sensitive-Data-In-Logs ✅ Passed Only adds base images and a periodic job config; no logging statements or sensitive data fields were introduced.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@Nirshal

Nirshal commented Jul 24, 2026

Copy link
Copy Markdown
Contributor Author

/pj-rehearse periodic-ci-openshift-hypershift-release-5.0-periodics-e2e-aro-hcp

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@Nirshal: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@Nirshal

Nirshal commented Jul 24, 2026

Copy link
Copy Markdown
Contributor Author

/retest

…hcp periodic

The aro-hcp-hypershift-e2e workflow requires aro-hcp-e2e-tests and
aro-hcp-e2e-tools images. Add them as base_images so they can be
resolved in the periodic context where no source build occurs.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@Nirshal

Nirshal commented Jul 27, 2026

Copy link
Copy Markdown
Contributor Author

/pj-rehearse periodic-ci-openshift-hypershift-release-5.0-periodics-e2e-aro-hcp

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@Nirshal: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@Nirshal: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
periodic-ci-openshift-hypershift-release-5.0-periodics-e2e-aws-autonode N/A periodic Ci-operator config changed
periodic-ci-openshift-hypershift-release-5.0-periodics-e2e-aws-ovn-conformance-serial N/A periodic Ci-operator config changed
periodic-ci-openshift-hypershift-release-5.0-periodics-e2e-aws-multi N/A periodic Ci-operator config changed
periodic-ci-openshift-hypershift-release-5.0-periodics-e2e-powervs-ovn N/A periodic Ci-operator config changed
periodic-ci-openshift-hypershift-release-5.0-periodics-e2e-ibmcloud-ovn-roks N/A periodic Ci-operator config changed
periodic-ci-openshift-hypershift-release-5.0-periodics-e2e-aws-ovn N/A periodic Ci-operator config changed
periodic-ci-openshift-hypershift-release-5.0-periodics-e2e-aro-hcp N/A periodic Periodic changed
periodic-ci-openshift-hypershift-release-5.0-periodics-hcm-azure-e2e-aks-upgrade-minor N/A periodic Ci-operator config changed
periodic-ci-openshift-hypershift-release-5.0-periodics-e2e-openstack-aws-csi-manila N/A periodic Ci-operator config changed
periodic-ci-openshift-hypershift-release-5.0-periodics-e2e-aws-conformance-calico-private N/A periodic Ci-operator config changed
periodic-ci-openshift-hypershift-release-5.0-periodics-e2e-openstack-nested-conformance N/A periodic Ci-operator config changed
periodic-ci-openshift-hypershift-release-5.0-periodics-e2e-openstack-aws-nfv N/A periodic Ci-operator config changed
periodic-ci-openshift-hypershift-release-5.0-periodics-e2e-aws-conformance-cilium N/A periodic Ci-operator config changed
periodic-ci-openshift-hypershift-release-5.0-periodics-e2e-v2-aws N/A periodic Ci-operator config changed
periodic-ci-openshift-hypershift-release-5.0-periodics-e2e-ibmcloud-ovn-iks N/A periodic Ci-operator config changed
periodic-ci-openshift-hypershift-release-5.0-periodics-e2e-v2-gke N/A periodic Ci-operator config changed
periodic-ci-openshift-hypershift-release-5.0-periodics-e2e-aws-upgrade N/A periodic Ci-operator config changed
periodic-ci-openshift-hypershift-release-5.0-periodics-e2e-aws-ovn-conformance-fips N/A periodic Ci-operator config changed
periodic-ci-openshift-hypershift-release-5.0-periodics-e2e-openstack-aws-csi-cinder N/A periodic Ci-operator config changed
periodic-ci-openshift-hypershift-release-5.0-periodics-e2e-openstack-aws N/A periodic Ci-operator config changed
periodic-ci-openshift-hypershift-release-5.0-periodics-e2e-aws-conformance-calico N/A periodic Ci-operator config changed
periodic-ci-openshift-hypershift-release-5.0-periodics-e2e-openstack-aws-conformance N/A periodic Ci-operator config changed
periodic-ci-openshift-hypershift-release-5.0-periodics-e2e-aws-external-oidc N/A periodic Ci-operator config changed
periodic-ci-openshift-hypershift-release-5.0-periodics-e2e-aws-ovn-conformance-techpreview N/A periodic Ci-operator config changed
periodic-ci-openshift-hypershift-release-5.0-periodics-e2e-kubevirt-azure N/A periodic Ci-operator config changed

A total of 39 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci

openshift-ci Bot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

@Nirshal: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/periodic-ci-openshift-hypershift-release-5.0-periodics-e2e-aro-hcp c80ee14 link unknown /pj-rehearse periodic-ci-openshift-hypershift-release-5.0-periodics-e2e-aro-hcp

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@bryan-cox

Copy link
Copy Markdown
Member

/approve

@openshift-ci

openshift-ci Bot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bryan-cox, Nirshal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants